Skip to content

Conversation

@tgriesser
Copy link
Member

@tgriesser tgriesser commented Nov 18, 2025

Additional details

Deals with situations where larger than expected config values are coming through to the Cloud APIs inadvertently for certain route paths.

Steps to test

Added test

How has the user experience changed?

Fixes API errors for large serialized webpack configs

PR Tasks


Note

Filters large/duplicated config values before posting instance tests to Cloud, updating record flow, tests, and changelog.

  • Backend / Cloud API:
    • postInstanceTests now sends a filtered config using filterRuntimeConfigForRecording, removing rawJson/resolved, masking env values (e.g., omitted: type), and setting devServer.{webpackConfig|viteConfig} to omitted.
    • Imports filterRuntimeConfigForRecording and applies it when constructing request body.
  • Config Utilities:
    • Added filterRuntimeConfigForRecording(config) in packages/server/lib/config.ts to strip arbitrarily large/duplicated fields from runtime config prior to recording.
  • Recording Flow:
    • Simplified runtime config merge in record.ts to { ...config, ...runtimeConfig } (removed resolved-origin annotations).
  • Tests:
    • Unit test asserts Cloud API strips large config values and masks env.
    • System test expectations updated (remove resolved.* assertions).
  • Changelog:
    • Adds bugfix entry noting issues with large config values when recording to Cypress Cloud.

Written by Cursor Bugbot for commit dd67d03. This will update automatically on new commits. Configure here.

@cypress
Copy link

cypress bot commented Nov 18, 2025

cypress    Run #67424

Run Properties:  status check passed Passed #67424  •  git commit dd67d03f1a: fix tests after dropping resolved
Project cypress
Branch Review tgriesser/fix/filter-large-user-supplied-values
Run status status check passed Passed #67424
Run duration 18m 56s
Commit git commit dd67d03f1a: fix tests after dropping resolved
Committer Tim Griesser
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 12
Tests that did not run due to a developer annotating a test with .skip  Pending 1098
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26689
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  97.98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

…values

* develop:
  chore: bump resource class for driver-integration-electron (#32959)
  chore(deps): update dependency @types/enzyme to v3.10.19 (#32961)
  chore: fix link to publish-binary job (#32949)
@tgriesser tgriesser merged commit ae46f1e into develop Nov 19, 2025
90 of 92 checks passed
@tgriesser tgriesser deleted the tgriesser/fix/filter-large-user-supplied-values branch November 19, 2025 14:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 19, 2025

Released in 15.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v15.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants